Add call to irm at market creation #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Grimal
requested review from
MathisGD,
MerlinEgalite,
QGarchery and
Rubilmax
QGarchery
force-pushed
the
fix/issue-259
branch
from
8d8a88e to
4ac8778
Compare
Contributor
|
Updated so that it does not contain the commits on main. The CI is expected to fail on Certora because now there are other ways the |
Rubilmax
approved these changes
Dec 7, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Rubilmax
approved these changes
Dec 7, 2023
Co-authored-by: Romain Milon <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Rubilmax
approved these changes
Dec 7, 2023
Co-authored-by: Merlin Egalite <[email protected]> Signed-off-by: Jean-Grimal <[email protected]>
Rubilmax
approved these changes
Dec 7, 2023
MerlinEgalite
approved these changes
Dec 7, 2023
MathisGD
reviewed
Dec 8, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Rubilmax
force-pushed
the
fix/issue-259
branch
from
95e3225 to
4d68d40
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Rubilmax
force-pushed
the
fix/issue-259
branch
from
95e3225 to
4d68d40
Compare
Rubilmax
approved these changes
Dec 11, 2023
MathisGD
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://cantina.xyz/ai/d86b7f95-e574-4092-8ea2-78dcac2f54f1/findings/3a235a1b-ddb4-4f7f-b254-0c940a832814
This issue doesn't really have a meaningful impact, so we could just acknowledge it as well.